corrected translation to english errors in 'var' lesson #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tgentry300 wants to merge 1 commit into javascript-tutorial:master from tgentry300:master

Closed

corrected translation to english errors in 'var' lesson #456

tgentry300 wants to merge 1 commit into javascript-tutorial:master from tgentry300:master

Conversation

@tgentry300

Copy link

@tgentry300 tgentry300 commented Jul 3, 2018

No description provided.

@tgentry300


 corrected translation to english errors in 'var' lesson

8ac9524

@CLAassistant

Copy link

CLAassistant commented Jul 3, 2018 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

@iliakan

Copy link

Member

iliakan commented Jul 3, 2018

Are you a native speaker?

davegregg

davegregg approved these changes

Jul 5, 2018

View reviewed changes

@davegregg

Copy link

Contributor

davegregg commented Jul 5, 2018

Yes, @iliakan, he's one of my students.

iliakan

iliakan requested changes

Jul 5, 2018

View reviewed changes

1-js/06-advanced-functions/04-var/article.md

```

Because all `var` declarations are processed at the function start, we can reference them at any place. But variables are undefined until the assignments.

Because all `var` declarations are processed at the function start, we can reference them at any place. But variables are undefined until they are explicitly defined.

Copy link

Member

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undefined until they are explicitly assigned (=).

1-js/06-advanced-functions/04-var/article.md

1. Variables have no block scope, they are visible minimum at the function level.

2. Variable declarations are processed at function start.

1. `var`Variables have no block scope, they are not block-local and can be accessed from any point in the script.

Copy link

Member

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong, they are function-local, so can't be "accessed from any point in the script" =)

Copy link

Member

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if rephrasing is good here...

Copy link

Contributor

@davegregg davegregg Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rephrasing is good here. In this case, I had intended to submit another PR to add precision.

Copy link

Contributor

@davegregg davegregg Jul 5, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps: Variables declared with `var` have function-level scope, instead of block-level scope.

Copy link

Member

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iliakan

Copy link

Member

iliakan commented Jul 5, 2018

Let's ensure maximum clarity and correctness with this subtle topic.

iliakan

iliakan reviewed

Aug 4, 2018

View reviewed changes

1-js/06-advanced-functions/04-var/article.md

But `var` is a very different beast, that originates from very old times. It's generally not used in modern scripts, but still lurks in the old ones.

If you don't plan meeting such scripts you may even skip this chapter or postpone it, but then there's a chance that it bites you later.

If you don't plan on reading or editing such scripts you may even skip this chapter, but there is a chance that you will see `var` in old scripts that you are reading and/or editing.

Copy link

Member

@iliakan iliakan Aug 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double wording: reading/editing.

iliakan

iliakan requested changes

Aug 4, 2018

View reviewed changes

Copy link

Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments please. Or is the PR dead?

@iliakan iliakan closed this

Aug 30, 2018

Labels

None yet

4 participants

@tgentry300 @CLAassistant @iliakan @davegregg

corrected translation to english errors in 'var' lesson #456

corrected translation to english errors in 'var' lesson #456

Uh oh!

Conversation

@tgentry300 tgentry300 commented Jul 3, 2018

Uh oh!

CLAassistant commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iliakan commented Jul 3, 2018

Uh oh!

davegregg commented Jul 5, 2018

Uh oh!

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

Uh oh!

@davegregg davegregg Jul 5, 2018

Choose a reason for hiding this comment

Uh oh!

@davegregg davegregg Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Jul 5, 2018

Choose a reason for hiding this comment

Uh oh!

iliakan commented Jul 5, 2018

Uh oh!

@iliakan iliakan Aug 4, 2018

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Jul 3, 2018 •

edited

Loading

@davegregg davegregg Jul 5, 2018 •

edited

Loading