-
Notifications
You must be signed in to change notification settings - Fork 4k
Improving "Garbage collection" article #3723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously, it said "painted", which seems less clear than "shown".
Though em dashes are great, they're not always the tool for the job.
@joaquinelio
joaquinelio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tutorial have many grammar issues.
I'd focus there, actual errors
Still,
There are many good PR piling up...
Lack of reviewers
...
Backticks are there on purpose. They format the view (usually reserved words),resuling in a highlighted text, a quoted "user" in this case.
Why not dashes?
They are perfect. Allowed and clearer.
I love them so much that I leave them even in Spanish where they are not allowed. Take that, Real Academia Española.
"anymore", maybe, I dont know if mandatory
"the" and "-s" added,
some simplifications,
Look like real fixes.
I noticed a thing or two that could be better, so I went ahead and fixed them myself.
For changes that seem less obvious, I explain in the commit message. However, maybe something that was obvious to me is not obvious to you, so feel free to ask for further explanation.
Suggestions are welcome!