-
Notifications
You must be signed in to change notification settings - Fork 4k
Improving "Object references and copying" article #3722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TurekBot
wants to merge
6
commits into
javascript-tutorial:master
from
TurekBot:object-references-and-copying
Open
Improving "Object references and copying" article #3722
TurekBot
wants to merge
6
commits into
javascript-tutorial:master
from
TurekBot:object-references-and-copying
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here, someone's mistakenly created en dashes, when they intended to create em dashes. En dashes are used to separate numbers. Reference: https://www.thepunctuationguide.com/en-dash.html Em dashes are used to emphatically set apart. Reference: https://www.thepunctuationguide.com/em-dash.html
e.g. is a sneaky guy that sounds like "example", but really means "that is"
Instead of "loop ... examines ... and replicate" we now use "loop ... examines ... and replicates".
@javascript-translate-bot
javascript-translate-bot
added
the
review needed
Review needed, please approve or request changes
label
Jul 21, 2024
@javascript-translate-bot
javascript-translate-bot
requested a review
from a team
July 21, 2024 03:32
That was my mistake from earlier—but I'm fixing it!
Member
@joaquinelio
joaquinelio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyphens "--" are there on purpose, is metadata, result in a dash " – " on the view
Grammar
I am not a native english speaker.
- I thought it was
"then (we do) replicate..."
"then (the code) replicateS" sound better o me. - "and then, if..." sounds better too, about where the action is.
Again, a native should review.
Minor changes look ok
Not a fan when they are not strictly errors, as they pile up and become a pain for translated repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I noticed a few things that could be better, so I went ahead and fixed them. Explanations for each change are in the corresponding commit message.
Suggestions are welcome!