Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Polyfill.io has been flagged as a server malware. #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CSKishan wants to merge 1 commit into javascript-tutorial:master
base: master
Choose a base branch
Loading
from CSKishan:master

Conversation

@CSKishan
Copy link

@CSKishan CSKishan commented Jul 4, 2024

Supply chain attack noticed in over 100,000 websites using polyfill.io.

Replaced with a safer alternative (polyfill-fastly.io)

kricsleo reacted with thumbs up emoji
Supply chain attack noticed in over 100,000 websites using polyfill.io.
Replaced with a safer alternative (polyfill-fastly.io)
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jul 4, 2024
Copy link
Contributor

kricsleo commented Jul 5, 2024
edited
Loading

Same here, and more informations:

polyfill.io has been proven to be evil as it recently started implanting malicious scripts to jump to gambling sites.

https://blog.cloudflare.com/automatically-replacing-polyfill-io-links-with-cloudflares-mirror-for-a-safer-internet

height = height ?? 100;

// after running the transpiler
height = (height !== undefined && height !== null) ? height : 100;
Copy link
Contributor

@FloffyGarlic FloffyGarlic Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, these two lines do the exact same thing, but since the old one is much easier to understand, it's better. If some parentheses make code easier to read, they should stay. I don't approve of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FloffyGarlic FloffyGarlic FloffyGarlic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review needed Review needed, please approve or request changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /