Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update article.md #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smith558 merged 1 commit into javascript-tutorial:master from ellie-heidari:patch-1
Jul 8, 2024
Merged

Conversation

@ellie-heidari
Copy link
Contributor

@ellie-heidari ellie-heidari commented May 10, 2024

Small change in the sentence.

Small change in the sentence.
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label May 10, 2024
Copy link

CLAassistant commented May 10, 2024
edited
Loading

CLA assistant check
All committers have signed the CLA.

@smith558 smith558 self-assigned this May 10, 2024
Copy link
Member

( I'm not a native English speaker)

Interesting.
I think both are correct, but it's not about grammar. They are not strictctly logically the same.

Maybe the change is easier to read, still correct?

Copy link

@Afirestriker Afirestriker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar Checked. LGTM

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels May 14, 2024
komalagra

This comment was marked as resolved.

Copy link

@komalagra komalagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@FloffyGarlic FloffyGarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. The correction definitely feels more natural

@smith558 smith558 merged commit 815fafa into javascript-tutorial:master Jul 8, 2024
Copy link
Member

smith558 commented Jul 8, 2024

Thank you for your contribution! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smith558 smith558 smith558 approved these changes

+3 more reviewers

@komalagra komalagra komalagra approved these changes

@Afirestriker Afirestriker Afirestriker approved these changes

@FloffyGarlic FloffyGarlic FloffyGarlic approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

needs +1 One more review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /