-
Notifications
You must be signed in to change notification settings - Fork 4k
fix link to ECMA-262 specification #3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
@Afirestriker
Afirestriker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
slevithan
commented
Jun 18, 2024
This PR is incorrect. It arbitrarily links to the ancient v5.1 of the spec.
The current link is fine. It just redirects to https://ecma-international.org/publications-and-standards/standards/ecma-262/
Three options:
- Keep the current link, which redirects.
- Update to the new URL (redirect target).
- Use https://tc39.es/ecma262/ which is always the most up-to-date ECMAScript spec (including any finished proposals).
Any of the above seem okay, but not accepting this PR as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should link to the latest standard, not v5.1 from 2011.
javascript-translate-bot
commented
Jun 18, 2024
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
sneeed
commented
Jun 18, 2024
/done
Thanks for the feedback.
I think your option 3 would be best and changed it accordingly.
old link was broken