Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed image display issue + smart header issue #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
engag1ng wants to merge 17 commits into javascript-tutorial:master from engag1ng:master
Closed

Fixed image display issue + smart header issue #3683

engag1ng wants to merge 17 commits into javascript-tutorial:master from engag1ng:master

Conversation

@engag1ng
Copy link

@engag1ng engag1ng commented Apr 18, 2024
edited
Loading

  • iframe was not displaying so I added screenshots instead.
  • Smart header had four backticks instead of three backticks

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Apr 18, 2024
Copy link

CLAassistant commented Apr 18, 2024
edited
Loading

CLA assistant check
All committers have signed the CLA.

@smith558 smith558 self-assigned this Apr 18, 2024
Copy link
Member

@engag1ng Hi! The iframes are loading just fine for me. Could you provide more details/screenshots of what's not working for you?

Copy link
Author

image
This is another thing with the HTML code not loading from src.

image
This is how every iframe looks for me.

I already tried to open the repo with another browser (Chrome) because I thought that Brave was maybe blocking iframes but no success. Seems like nothing with a src tag loads.

Copy link
Member

joaquinelio commented Apr 18, 2024
edited
Loading

About smart header 4 backticks

Did you test it?
There are 4 for a reason, they are nested blocks. There's a big smart box that includes smaller 3 tick code blocks.
Nested blocks dont work in github, that's why you need to test it in a local server

Copy link
Member

About smart header 4 backticks

Did you test it? There are 4 for a reason, they are nested blocks. There's a big smart box that includes smaller 3 tick code blocks. Nested blocks dont work in github, that's why you need to test it in a local server

Good catch!

Copy link
Author

About smart header 4 backticks

Did you test it? There are 4 for a reason, they are nested blocks. There's a big smart box that includes smaller 3 tick code blocks. Nested blocks dont work in github, that's why you need to test it in a local server

What do you mean with local server? You mean clone it locally and open it in a Markdown viewer? On that topic, any recommendations for MD Viewers?

Copy link
Author

My bad. Didn't realise that you shouldn't view this on GitHub but rather on the website. Closing now. But thanks for the quick support :)

Copy link
Member

@engag1ng Thanks for your effort anyway! 🙂

Copy link
Member

joaquinelio commented Apr 19, 2024
edited
Loading

https://github.com/javascript-tutorial/server

Good luck! @engag1ng

As a Spanish turorial maintainer,
I Did my part, there and here, with both successful and rejected contribs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

review needed Review needed, please approve or request changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /