-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix grammar and typos #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar and typos #3634
Conversation
smith558
commented
May 5, 2024
@nakhodkin Thank you for your contribution! 🙂
joaquinelio
commented
May 5, 2024
I don't review grammar because I'm not native speaker
But I think the fix on line 258 is incorrect, the comma is needed.
If we want to check if itemexists in the array, and don't need the index, thenarr.includes is preferred.
I don't review grammar because I'm not native speaker
But I think the fix on line 258 is incorrect, the comma is needed.
If we want to check ifitemexists in the array, and don't need the index, thenarr.includesis preferred.
A comma before "and" is almost always optional. I belive it's the case here as well.
No description provided.