Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update article #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gleb-Pastushenko wants to merge 1 commit into javascript-tutorial:master
base: master
Choose a base branch
Loading
from Gleb-Pastushenko:patch-1

Conversation

@Gleb-Pastushenko
Copy link
Contributor

@Gleb-Pastushenko Gleb-Pastushenko commented Mar 19, 2023

Method shorthand added to Summary

Method shorthand added to Summary
Copy link

CLAassistant commented Mar 19, 2023
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gleb-Pastushenko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

- Functions that are stored in object properties are called "methods".
- Method shorthand can be used instead of function expression:
const User {
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Mar 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this needs to be:
const user = {
here and below (missing = and lowercased variable as this is not class name).
Also it seems the code fragments lack backticks.

Copy link
Contributor Author

Gleb-Pastushenko commented Mar 19, 2023 via email

Sorry for mistakes. I'll fix it right now in a new request. вс, 19 мар. 2023 г. в 14:42, Vse Mozhe Buty ***@***.***>:
...
***@***.**** commented on this pull request. ------------------------------ In 1-js/04-object-basics/04-object-methods/article.md <#3411 (comment)> : > @@ -259,6 +259,16 @@ That's a special feature of arrow functions, it's useful when we actually do not ## Summary - Functions that are stored in object properties are called "methods". +- Method shorthand can be used instead of function expression: + + const User { It seems this needs to be: const user = { here and below (missing = and lowercased variable as this is not class name). Also it seems the code fragments lack backticks. — Reply to this email directly, view it on GitHub <#3411 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF75Z4BPEUIGOSAN7EAT653W435JVANCNFSM6AAAAAAWACL3CI> . You are receiving this because you authored the thread.Message ID: ***@***.*** .com>
vsemozhetbyt reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /