-
Notifications
You must be signed in to change notification settings - Fork 4k
grammar & legibility (to check) #3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
p2635
commented
Jan 28, 2023
The situation when the browser sent a request and has a pending connection with the server, is standard for this method. Only when a message is delivered, the connection is reestablished.
This is a horrible sentence in general. As a newbie, I have to read this 5 times, I don't even know what the main point is here. Is it just 'This is a standard method in most cases'? The rest of the sentence is repeating what the article already says:
- A request is sent to the server.
- The server doesn’t close the connection until it has a message to send.
- When a message appears – the server responds to the request with it.
- The browser makes a new request immediately.
p2635
commented
Jan 28, 2023
Also, I am confused by this:
Only when a message is delivered, the connection is reestablished.
This is conflicting with this:
- The server doesn’t close the connection until it has a message to send.
How can connection be reestablished? It was never closed. Maybe the author was meant to say 'Only when a message is delivered, a new request is made'.
If I get time, I am trying to review all the content for these problems #3335.
p2635
commented
Jan 28, 2023
A small recommendation, change the title of this PR to something more descriptive. For example: 'Check grammar/legibility for 'long polling' article' instead of 'grammar & legibility (to check)'.
joaquinelio
commented
Jan 29, 2023
Well, @p2635 , I tried to fix both issues here.
Any review/advice from a native Eng speaker would be nice...
I am a native English speaker, but I still need the original author to answer my questions above. I'm not a maintainer of the project, so I don't get to make the final decisions. We just need to be patient.
non-native warning
The problem: I fixed it the spanish way, maybe wrong.
I think the comma before "is" should be removed.
Workaround: 2 commas.