-
Notifications
You must be signed in to change notification settings - Fork 4k
Code typo in prompt example #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It initially had (title[, default]), but I'm not sure why you had the array notation there since default is usually a string. I decided to leave it on there since I'm sure you had your reasons.
Member
iliakan
commented
Jun 11, 2017
square brackets mean "optional"
athena0304
pushed a commit
to athena0304/javascript-tutorial-en
that referenced
this pull request
Jun 4, 2018
* Transfer the existing translation Co-authored-by: maoxiaoke <thebigyellowbee@qq.com> resolve javascript-tutorial#4 * fix(variables): Adjust some contents * fix(variables): translate more tasks and solutions * 👌 fix: Adjust some words due to code review changes Signed-off-by: sqrtthree <imsqrtthree@gmail.com> * Update task.md * Update article.md * fix: Remove some spaces due to code review changes Signed-off-by: sqrtthree <imsqrtthree@gmail.com>
iliakan
pushed a commit
that referenced
this pull request
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It initially had (title[, default]), but I'm not sure why you had the array notation there since default is usually a string. I decided to leave it on there since I'm sure you had your reasons. However, I think it would be more appropriate without the array notation.