Update article.md #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

iliakan merged 7 commits into javascript-tutorial:master from Zearin:patch-1

Mar 13, 2021

Merged

Update article.md #2440

iliakan merged 7 commits into javascript-tutorial:master from Zearin:patch-1

Mar 13, 2021

Conversation

@Zearin

Copy link

Contributor

@Zearin Zearin commented Jan 15, 2021

Minor edits for grammar, phrasing, and markup.

@Zearin


 Update article.md

bda37e2

Minor edits for grammar, phrasing, and markup.

@CLAassistant

Copy link

CLAassistant commented Jan 15, 2021 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

@iliakan

Copy link

Member

iliakan commented Jan 16, 2021 •

edited

Loading

Thanks, there should be changes though.

We don't use <dfn> tag.
Italic is *...*, not _..._
After "This is often the case for radio buttons or checkboxes" (note the single for "the case" here), we should say "this case", single, I guess?

Zearin added 2 commits

January 16, 2021 16:35

@Zearin


 Update article.md

18417c3

Edited according to feedback

@Zearin


 Update article.md

8806d5b

Rewrote phrasing pointed out in feedback

iliakan

iliakan requested changes

Jan 21, 2021

View reviewed changes

Copy link

Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you a native English speaker? Just for me to know ;)

2-ui/4-forms-controls/1-form-elements/article.md Outdated Show resolved Hide resolved

Zearin added 3 commits

January 25, 2021 10:55

@Zearin


 Update article.md

b93be73

@Zearin


 Update article.md

d78ce9c

@Zearin


 Update article.md

4711ee4

@Zearin

Copy link

Contributor Author

Zearin commented Jan 25, 2021

Are you a native English speaker? Just for me to know ;)

(Sorry for the late reply! I missed this comment.)

✔ Yes, I am a native English speaker.

@iliakan

Copy link

Member

iliakan commented Jan 25, 2021

Ok, please no comma after e.g. =)

@iliakan

Copy link

Member

iliakan commented Feb 2, 2021

Ping @Zearin ? ;)

@Zearin


 Remove comma after e.g. based on feedback

f014534

@Zearin

Copy link

Contributor Author

Zearin commented Feb 2, 2021

Ping @Zearin ? ;)

Sorry about that—and thanks for the ping!

✅ Comma removed.

@iliakan iliakan merged commit 175574e into javascript-tutorial:master

Mar 13, 2021

Sebastianokunkelo

Sebastianokunkelo reviewed

Mar 16, 2021

View reviewed changes

Copy link

@Sebastianokunkelo Sebastianokunkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zearin:patch-1

Labels

None yet

4 participants

@Zearin @CLAassistant @iliakan @Sebastianokunkelo

Update article.md #2440

Update article.md #2440

Uh oh!

Conversation

@Zearin Zearin commented Jan 15, 2021

Uh oh!

CLAassistant commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iliakan commented Jan 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@iliakan iliakan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zearin commented Jan 25, 2021

Uh oh!

iliakan commented Jan 25, 2021

Uh oh!

iliakan commented Feb 2, 2021

Uh oh!

Zearin commented Feb 2, 2021

Uh oh!

@Sebastianokunkelo Sebastianokunkelo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Jan 15, 2021 •

edited

Loading

iliakan commented Jan 16, 2021 •

edited

Loading