Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

redundant "use case" #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliakan merged 1 commit into javascript-tutorial:master from joaquinelio:patch-2
Oct 16, 2020
Merged

Conversation

@joaquinelio
Copy link
Member

@joaquinelio joaquinelio commented Oct 15, 2020

WIP ? What's wrong with it? Something new?

I just reviewed the translated article!!!!
give us a break

ok, just to report a redundancy, keep in mind in the new version.

@iliakan iliakan merged commit 1fbc508 into javascript-tutorial:master Oct 16, 2020
@joaquinelio joaquinelio deleted the patch-2 branch October 16, 2020 09:05
Copy link
Member Author

Just in case. You know I'm just kidding, dont you?

It's just a fresh article to add -redundancy fixed-...
Being obsolete before born...
Well... I suppose it's the price. Always up to date is what attracted me in the first case.

Copy link
Member

iliakan commented Oct 16, 2020

Frankly, I wasn't sure why you changed that, but the change wasn't bad, so I merged =)

Copy link
Member Author

Oh?
To grasp the use case, let's explore a use case.
Sounds wrong. Even in long Spanish sentences.

I didnt let it happen in Spanish. -if he accepts my suggest too-.

Copy link
Member

iliakan commented Oct 16, 2020

Ah, it's good then =)

Copy link
Member

iliakan commented Oct 16, 2020

Thanks.

Copy link
Member Author

Bytheway, my bot found another bug in yours:
"148 of 174"
That's terrible, people gets frustrated "the goal is so far".
It counts the example too.
I could check it to be even, but it would be... wrong.

Copy link
Member

iliakan commented Oct 16, 2020

Is that about pagination? Give me a screenshot please?

Copy link
Member Author

I'm really sorry.
I should stop wasting everyones time with my stupid jokes.

I meant this, no that interesting,
There are only 173

image

Copy link
Member

iliakan commented Oct 16, 2020

I have a lot of other ongoing stuff, so I probably miss the context sometimes.

So it shows 1 more than there really is?

Copy link
Member Author

Yes, if you are proud of your 174 articles you shouldn't. The first one is fake.

sorry I did it again. stoooop!
no big deal, silly jokes.

More importan things, "proxy and reflect",
How important is in advanced JS?
I never read it, but people that started left and they are not the same anymore.

Copy link
Member

iliakan commented Oct 16, 2020

Proxies are used... About once per year at most =)

But it's an interesting stuff to know, may come in handy.

mikitachyzhyk reacted with thumbs up emoji

Copy link
Member

iliakan commented Oct 16, 2020

Let me know if the article is bad, I'll update it then.

Copy link
Member

iliakan commented Oct 16, 2020
edited
Loading

Please be careful. Maybe it'd be wiser for you to abstain though 🤔

Copy link
Member Author

I'wont. But I'll ask...
Maybe not bad, but too long. The longest I think.

haha I just saw the warning, thanks
the "I wont" refered to "let me know"

Copy link
Member Author

wait... Proxy is just THE wrappers builder ?

It doesnt look too fancy, I just wonder why class inheritance does not cover every use case (but I didnt evolve too much from assembler).
PROXY is just the longest article you may consider to split (I won't decide if it is an issue).

Another long article is indexedDB (I didnt read it).
But I wouldnt't split it.

Copy link
Member

iliakan commented Oct 17, 2020

Proxy is ... a proxy. It's a wrapper around almost everything including functions. Object inheritance doesn't cover that. It's different.

Copy link
Member Author

wrappers and class inheritance work is very different, ok,
but when I try to solve something I look into inheritance first, extend the blueprint instead of the object
Can't do with built-in obj.
Ok, I'll read it.

Copy link
Member Author

Unrelated to EVERYTHING,

you may want to help other maintaners providing a list
Maintainer needs help to identify abandoned articles, without this we wouldt finish 1st part.
Article / user / date taken / PR
image

Copy link
Member

iliakan commented Oct 17, 2020

Sure, we can. Make it a table? Could you please make a separate issue in https://github.com/javascript-tutorial/es.javascript.info and include others into the discussion for the better progress issue view?

Copy link
Member Author

I don't need it. I did my own on glitchme (just... good enough)
The browser capture above is the real result.

I just recommend it for my colleagues around the world, maybe they didnt realize they need it.

When we took the repo, there were lots of taken and abandoned articles. Tracking them was difficult. Now it's fixed.
Your bot does the rest. You dont need anything else.

25 articles left.
With only 3 articles with no @user today,
the procedure is to clear inactive users with articles taken more than 2 months ago (I post the list with @ mention first) ,
Then a new collaborator just pops.

Reviewers dont pop. : (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /