-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix grammar and construction in 2.1.10 #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paroche
paroche
requested changes
Dec 19, 2019
Collaborator
@paroche
paroche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good or at least OK by me (as far as I noticed) except as noted.
Member
iliakan
commented
Dec 27, 2019
/me stands with @paroche on the review comments, please update the PR :)
Member
iliakan
commented
Jan 18, 2020
@galacemiguel Could you please fix the PR according to the suggestions?
Member
iliakan
commented
Sep 23, 2020
ping @galacemiguel 😮
Contributor
Author
galacemiguel
commented
Sep 23, 2020
@galacemiguel
galacemiguel
force-pushed
the
patch-1
branch
from
September 23, 2020 10:43
d53ba7c to
d3ad4c3
Compare
Contributor
Author
galacemiguel
commented
Sep 23, 2020
Member
iliakan
commented
Sep 23, 2020
Wow! So I've got to review it again! ;)
Member
iliakan
commented
Sep 23, 2020
Great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were various grammatical and construction-related errors in the Window sizes and scrolling article. I did my best to correct them.
Please let me know if I made a mistake myself! Thank you!