Minor text changes #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

iliakan merged 2 commits into javascript-tutorial:master from gwooly:patch-2

Aug 30, 2017

Merged

Minor text changes #149

iliakan merged 2 commits into javascript-tutorial:master from gwooly:patch-2

Aug 30, 2017

Conversation

@gwooly

Copy link

Contributor

@gwooly gwooly commented Aug 27, 2017

No description provided.

@gwooly


 Minor text changes

a264bf0

iliakan

iliakan requested changes

Aug 28, 2017

View reviewed changes

Copy link

Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, made a few comments.

1-js/05-data-types/01-primitives-methods/article.md

[cut]

Let's formulate the key distinction between primitives and objects.

Let's look at the key distinction between primitives and objects.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 'formulate' is bad here?

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formulate indicates creating mathematical operation, whereas this is comparing the differences, 'looking at' the differences makes more sense.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-js/05-data-types/01-primitives-methods/article.md Outdated

Can be created with `{}`, for instance: `{name: "John", age: 30}`. There are other kinds of objects in JavaScript, e.g. functions are objects.

One of the best things about objects is that we can store a function as one of properties:

One of the best things about objects is that we can store functions within them as properties:

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd refrain from saying "within an object", because technically functions are stored "by reference". Was the original wording bad?

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, "store" without "reference" implies a value is being stored. I would say "we can store a reference to a function as one of the properties"

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "reference" is not welcome here, because the reader does not know about references yet.

Is the original wording bad or acceptable?

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep the original for consistency, but alter slightly 'we can store a function as one of its properties'

1-js/05-data-types/01-primitives-methods/article.md Outdated

But, these features come with a cost!

Objects are "heavier" than primitives. They require additional resources to support the internal machinery. But properties and methods are useful in programming, JavaScript engines try to optimize them, so the price is usually fair.

Objects are "heavier" than primitives. They require additional resources to support the internal machinery. But as properties and methods are very useful in programming, JavaScript engines try to optimize them to reduce the additional burdon.

Copy link

Member

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "burden" (last word)?

Copy link

Contributor

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iliakan correct. "burden"

1-js/05-data-types/01-primitives-methods/article.md

2. The language allows to access methods and properties of strings, numbers, booleans and symbols.

3. When it happens, a special "object wrapper" is created that provides the functionality and then is destroyed.

2. The language allows access to methods and properties of strings, numbers, booleans and symbols.

3. When this happens, a special "object wrapper" is created that provides the extra functionality, and then is destroyed.

Copy link

Member

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "extra", why not just "the functionality" ?

Copy link

Contributor

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalent, but a bit more descriptive.

Copy link

Member

@iliakan iliakan Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-js/05-data-types/01-primitives-methods/article.md

Simple, right? Here's what actually happens in `str.toUpperCase()`:

1. The string `str` is a primitive. So in the moment of accessing its property a special object is created that both knows the value of the string and has useful methods, like `toUpperCase()`.

1. The string `str` is a primitive. So in the moment of accessing its property, a special object is created that knows the value of the string, and has useful methods, like `toUpperCase()`.

Copy link

Member

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...a special object is created that knows the value of the string, and has useful methods..." -- is the comma really needed here (before "and")?

Copy link

Contributor

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment about the Oxford comma.

Copy link

Member

@iliakan iliakan Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwooly please remove Oxford comma, not used in other articles.

1-js/05-data-types/01-primitives-methods/article.md

So primitives can provide methods, but they still remain lightweight.

Of course, a JavaScript engine highly optimizes that process. Internally it may skip the creation of the extra object at all. But it must adhere to the specification and behave as if it creates one.

The JavaScript engine highly optimizes this process. It may even skip the creation of the extra object at all. But it must still adhere to the specification and behave as if it creates one.

Copy link

Member

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the word "internally" to emphasize that the change is purely internal, not visible from the outside. Is it bad here?

Copy link

Contributor

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem equivalent to me. "Internally" is more descriptive, but the following sentence implies that something is happening "behind the scenes".

Copy link

Member

@iliakan iliakan Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gwooly

gwooly commented

Aug 28, 2017

View reviewed changes

Copy link

Contributor Author

@gwooly gwooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added comments.

@gwooly


 Made amendments to pull request as per comments

02cc728

iliakan

iliakan approved these changes

Aug 30, 2017

View reviewed changes

Copy link

Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@iliakan iliakan merged commit 10af994 into javascript-tutorial:master

Aug 30, 2017

athena0304 pushed a commit to athena0304/javascript-tutorial-en that referenced this pull request

Aug 21, 2018

@zhmhhu @leviding


 2-ui/1-document/01-browser-environment and 02-dom-nodes ( javascript-t...

69d1f23

...utorial#149)
* first commit
* second commit
* translation completed
* 格式修改
* 修正格式问题
* 修正格式问题

Labels

None yet

3 participants

@gwooly @iliakan @jmbothe

Minor text changes #149

Minor text changes #149

Uh oh!

Conversation

@gwooly gwooly commented Aug 27, 2017

Uh oh!

@iliakan iliakan left a comment

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@gwooly gwooly Aug 29, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 30, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 29, 2017

Choose a reason for hiding this comment

Uh oh!

@gwooly gwooly Aug 29, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 30, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 30, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@jmbothe jmbothe Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan Aug 30, 2017

Choose a reason for hiding this comment

Uh oh!

@gwooly gwooly left a comment

Choose a reason for hiding this comment

Uh oh!

@iliakan iliakan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants