-
Notifications
You must be signed in to change notification settings - Fork 4k
grammar, usage, punctuation edits, Part 1, sections 3.1 - 4.6 #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iliakan
commented
Aug 15, 2017
@jmbothe What you think about this PR: https://github.com/iliakan/javascript-tutorial-en/pull/139/files, is it a correct change?
@iliakan
iliakan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb, just please take a look at few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Use it everywhere you can" - does that really sound good here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliakan This change is grammatically correct. The extra "where" is redundant. And to answer "does it sound good here": yes, this sounds like natural English. It fits your conversational style well, I think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess, a typo (space lost), fix please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliakan Sorry! this is my mistake. I will fix it, and I will be more careful next time :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that a dash is wrong here? The phrases look better with it. Are the English rules really so strict that there must be no dash, or maybe a kind of "author punctuation" is possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliakan This change is correct punctuation, but as far as whether the sentence look better with dashes: that is a stylistic choice for you to make. But considering punctuation only, the "Follow..." clauses are dependent clauses of the rest of the sentence. In English when a dependent clause precedes an independent clause, we usually place a comma between them, although the comma is optional. It is considered incorrect to separate a dependent clause and an independent clause with a dash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'd just like to introduce a pause there. Using a comma is all right? Should I accept the current variant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a comma is good for introducing a pause here. It represent logical separation of the clauses, and a natural pause in reading/speaking rhythm.
cb5b1c6 to
374db1e
Compare
...tutorial#138) * 翻译完成 * fix * Update task.md * Update task.md * Update solution.md * Update task.md * Update article.md * Update article.md
No description provided.