Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ignore failing tests #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pzygielo wants to merge 1 commit into javaee-samples:master from pzygielo:ignore-failing-tests
Closed

Ignore failing tests #39

pzygielo wants to merge 1 commit into javaee-samples:master from pzygielo:ignore-failing-tests

Conversation

Copy link

@pzygielo pzygielo commented May 30, 2019
edited
Loading

I propose to convert failing travis/default build of master, to new issue and @Ignore failing tests.
Tests were broken in #34, with explanation provided there. IMO new issue that would remind to remove this exclusion once [not sure about condition] is met, would be better than failing build.
(Or perhaps warning for skipped tests is better than new issue, I do not know.)

Although #34 declares

changes that now make tests failing in Payara

I checked that for -P glassfish-embedded,!payara-ci-managed (i.e. for glassfish) the same happens.

Copy link
Contributor

@pzygielo In this specific project, tests are actually allowed to fail, as they indicate the project which they test against is faulty and the vendor should fix the issue. The test is not broken, but for that test Payara is.

It agree that is does make it difficult to see if new tests fail or not. We've all been trained (me too) to strive for passing builds, but this project is thus a little different. @Ignore is unfortunately not correct here.

pzygielo reacted with thumbs up emoji

@pzygielo pzygielo deleted the ignore-failing-tests branch May 30, 2019 16:01
Copy link
Author

I think it would be better to have such test in vendor(s) suite, and not in samples. From samples I'd expect to pass rather than show faults in used components (regardless of ci-job disclaimer).

With failing test, one always has to check the reason for failure. And having two failing just on start (that are not announced to be known to fail by default in any way in code), although somehow educational, isn't quite nice experience to begin with.

@Ignore is not marker of broken test (Probably I should have written Build was broken instead of Tests were broken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /