-
Notifications
You must be signed in to change notification settings - Fork 245
Fixed #23 ClientConfig differs between appservers #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #23 ClientConfig differs between appservers #24
Conversation
- test was successful if run against remote servers, but failed with embedded The cause was that the default server's private embedded payara provider is incompatible with the jerseys's - solution: configure the jersey client to be independent on server settings/impl - also done some cleanup and comments - the test is faster now and has timeout set (hangouts were possible) - no asserts lost now (try/catch/stacktrace replaced with collecting junit exceptions from each event processing and asserting that all assertions passed and no exception was thrown)
Looks good too. Small remark is that the final modifiers and this prefixes are mostly not really needed, but alas, it's a small thing ;)
It depends, I often do some big refactorings in very ugly code and then they are helpful for readibility and even to avoid unwanted collisions. But I will respect rules in this repo next time (I see many "fightings" of tabs vs. spaces here too) ;)
Thanks! It's probably not "fightings", just mistakes ;) The rule should be spaces for this repo.
...-tests-ee10-compatible FISH-6410: updating to jakarta 10 compatibility
The cause was that the default server's private embedded payara provider is
incompatible with the jerseys's
exceptions from each event processing and asserting that all assertions passed
and no exception was thrown)