Skip to content

tasks 223-232 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

javadev merged 7 commits into javadev:main from IvanMenov:tasks_223_to_232

Nov 27, 2021

Merged

tasks 223-232 #62

javadev merged 7 commits into javadev:main from IvanMenov:tasks_223_to_232

Nov 27, 2021

Conversation

Copy link

Contributor

@IvanMenov IvanMenov commented Nov 27, 2021

No description provided.

IvanMenov added 7 commits

November 27, 2021 10:28


 tasks 223-232

809222b


 add braces plus other fixes

17c614d


 fix problems

55739af


 fixes

4d8e267


 fix formatting

1d6b845

fix

aa4dd98

fix

129a20e

@sonarqubecloud

Copy link

sonarqubecloud bot commented Nov 27, 2021

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

javadev reviewed

View reviewed changes

src/main/java/g0201_0300/s0232_implement_queue_using_stacks/readme.md

**Output:** \[null, null, null, 1, 1, false\]

**Explanation:** MyQueue myQueue = new MyQueue(); myQueue.push(1); // queue is: \[1\] myQueue.push(2); // queue is: \[1, 2\] (leftmost is front of the queue) myQueue.peek(); // return 1 myQueue.pop(); // return 1, queue is \[2\] myQueue.empty(); // return false

Copy link

Owner

@javadev javadev Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be changed with ident format.

javadev reviewed

View reviewed changes

src/test/java/g0201_0300/s0225_implement_stack_using_queues/MyStackTest.java

assertThat(stack.top, equalTo(2));

assertThat(stack.pop(), equalTo(2));

Copy link

Owner

@javadev javadev Nov 27, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty lines may be removed.

javadev reviewed

View reviewed changes

src/main/java/g0201_0300/s0225_implement_stack_using_queues/readme.md

**Output:** \[null, null, null, 2, 2, false\]

**Explanation:** MyStack myStack = new MyStack(); myStack.push(1); myStack.push(2); myStack.top(); // return 2 myStack.pop(); // return 2 myStack.empty(); // return False

Copy link

Owner

@javadev javadev Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be changed with the ident format.

javadev reviewed

View reviewed changes

src/main/java/g0201_0300/s0224_basic_calculator/Solution.java

public int calculate(String s) {

char[] ca = s.toCharArray();

Copy link

Owner

@javadev javadev Nov 27, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty line may be removed.

javadev reviewed

View reviewed changes

src/main/java/g0201_0300/s0228_summary_ranges/Solution.java

strB.append("->").append(b);

}

ranges.add(strB.toString());

Copy link

Owner

@javadev javadev Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty line may be removed.

javadev reviewed

View reviewed changes

src/main/java/g0201_0300/s0225_implement_stack_using_queues/MyStack.java

int popValue = queueOne.remove();

queueOne.addAll(queueTwo);

queueTwo.clear();

Copy link

Owner

@javadev javadev Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty line may be removed.

javadev reviewed

View reviewed changes

src/main/java/g0201_0300/s0224_basic_calculator/Solution.java

}

public int helper(char[] ca) {

Copy link

Owner

@javadev javadev Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty line may be removed.

@javadev javadev merged commit 34c3862 into javadev:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@IvanMenov @javadev