-
Notifications
You must be signed in to change notification settings - Fork 93
tasks 160- 172, without 161,163,170 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We compare ListNode by pointers not by value. The custom comparator may be applied for a solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to compare ListNode by pointer, not by value.
There is an instruction for the readme.md generation tool:
https://github.com/javadev/LeetCode-in-Java/releases/tag/generatemd
The jar file itself:
https://github.com/javadev/LeetCode-in-Java/releases/download/generatemd/generatemd-1.0.jar
Those codecov/patch, codecov/project check that were not successful was beacause the test cover only one scenario, as we agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution works for me:
public class Solution { public ListNode getIntersectionNode(ListNode headA, ListNode headB) { ListNode node1 = headA; ListNode node2 = headB; while (node1 != node2) { node1 = node1 == null ? headB : node1.next; node2 = node2 == null ? headA : node2.next; } return node1; } }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why toString?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above implementation, that you wrote results in nullpoinerexception in the test case, as node1 == node2 evaluates to false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in leetcode. There are no exceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why static?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be the same ListNode(8) for both lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to use solution without split.
class Solution { public int compareVersion(String version1, String version2) { // acquire first number int numA = 0; int i; for(i=0; i<version1.length(); i++){ char c = version1.charAt(i); if(c == '.'){ break; }else{ numA = numA*10 + ((int)c - 48); } } // acquire second number int numB = 0; int j; for(j=0; j<version2.length(); j++){ char c = version2.charAt(j); if(c == '.'){ break; }else{ numB = numB*10 + ((int)c - 48); } } // compare if(numA > numB){ return 1; }else if(numA < numB){ return -1; }else{ // equal String v1 = ""; String v2 = ""; if(i != version1.length()) v1 = version1.substring(i+1); if(j != version2.length()) v2 = version2.substring(j+1); // if both versions end here, they are equal if(v1.equals("") && v2.equals("")){ return 0; }else{ return compareVersion(v1, v2); } } } }
Kudos, SonarCloud Quality Gate passed! Quality Gate passed
Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells
No description provided.