Skip to content

Added tasks 345, 349. #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

javadev merged 10 commits into javadev:main from ThanhNIT:tasks-345-349

Dec 11, 2021

Merged

Added tasks 345, 349. #106

javadev merged 10 commits into javadev:main from ThanhNIT:tasks-345-349

Dec 11, 2021

Conversation

javadev

Copy link

Owner

@javadev javadev commented Dec 11, 2021

No description provided.

TristianMa added 2 commits

December 11, 2021 11:58


 Added task 345

f013243


 update task 345, add task 349

de5e813

javadev commented

View reviewed changes

src/test/java/g0301_0400/s0345_reverse_vowels_of_a_string/SolutionTest.java Outdated

@Test

void reverseVowels() {

assertThat(

new g0301_0400.s0345_reverse_vowels_of_a_string.Solution().reverseVowels("hello"),

Copy link

Owner Author

@javadev javadev Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be class name without package.

src/test/java/g0301_0400/s0349_intersection_of_two_arrays/SolutionTest.java Outdated

@Test

void intersection() {

assertThat(

new g0301_0400.s0349_intersection_of_two_arrays.Solution()

Copy link

Owner Author

@javadev javadev Dec 11, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a class name without package.

javadev commented

View reviewed changes

src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java Outdated

}

}

int[] result = new int[intersectionList.size()];

for (int i = 0; i < intersectionList.size(); i++) result[i] = intersectionList.get(i);

Copy link

Owner Author

@javadev javadev Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java:[20] (blocks) NeedBraces: 'for' construct must use '{}'s.

@javadev javadev changed the title ~~(削除) Added tasks 345-349. (削除ここまで)~~ (追記) Added tasks 345, 349. (追記ここまで)

javadev commented

View reviewed changes

src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java Outdated

import java.util.ArrayList;

import java.util.List;

// #Easy #Array #Hash_Table #Sorting #Binary_Search #Two_Pointers

Copy link

Owner Author

@javadev javadev Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move comment after package.


 fix comments

9ac2472

javadev commented

View reviewed changes

src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java Outdated

List<Integer> intersectionList = new ArrayList<>();

for (int j : nums1) {

for (int k : nums2) {

Copy link

Owner Author

@javadev javadev Dec 11, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use faster solution, this is too slow.

javadev commented

View reviewed changes

src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java Outdated

for (int j : nums1) {

for (int k : nums2) {

if (j == k && !intersectionList.contains(j)) {

intersectionList.add(j);

Copy link

Owner Author

@javadev javadev Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may use solution filter.

Copy link

Contributor

@ThanhNIT ThanhNIT Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will update

javadev commented

View reviewed changes

src/main/java/g0301_0400/s0345_reverse_vowels_of_a_string/Solution.java Outdated

i++;

j--;

}

return String.copyValueOf(str1);

Copy link

Owner Author

@javadev javadev Dec 11, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this solution.

class Solution {
 private boolean isVowel(char c) {
 return c == 'a' || c == 'e' || c == 'i' || c == 'o' || c == 'u' 
|| c == 'A' || c == 'E' || c == 'I' || c == 'O' || c == 'U';
 }
 private StringBuilder swap(StringBuilder s, int l, int r) {
 char tmp = s.charAt(l);
 s.setCharAt(l, s.charAt(r));
 s.setCharAt(r, tmp);
 return s;
 }
 public String reverseVowels(String s) {
 int l = 0;
 int r = s.length() - 1;
 StringBuilder res = new StringBuilder(s);
 while (l < r) {
 while (l < r && !isVowel(s.charAt(l))) {
 l++;
 }
 while (l < r && !isVowel(s.charAt(r))) {
 r--;
 }
 res = swap(res, l, r);
 l++;
 r--;
 }
 return res.toString();
 }
}

Copy link

Owner Author

javadev commented Dec 11, 2021

You may use other email for commits

Thanh829 <tristian.ma@watasolutions.com>

git config user.name "John Doe"
git config user.email johndoe@example.com

javadev commented

View reviewed changes

src/main/java/g0301_0400/s0345_reverse_vowels_of_a_string/Solution.java Outdated

static boolean isVowel(char c) {

return (c == 'a' || c == 'A' || c == 'e' || c == 'E' || c == 'i' || c == 'I' || c == 'o'

|| c == 'O' || c == 'u' || c == 'U');

class Solution {

Copy link

Owner Author

@javadev javadev Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add public.

TristianMa and others added 3 commits

December 11, 2021 22:19

@TristianMa @ThanhNIT


 update solution for task 345 and 349

4d19148


 fix comment

0ab5856


 format code

javadev commented

View reviewed changes

src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java Outdated

for(int i=0;i<nums1.length;i++) occ[nums1[i]]=true;

List<Integer> res=new ArrayList<>();

for(int i=0;i<nums2.length;i++){

if(occ[nums2[i]]){

Copy link

Owner Author

@javadev javadev Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format source codes.

Copy link

Owner Author

javadev commented Dec 11, 2021

Theare are checkstyle warnings

Error: src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java:[10,20] (misc) ArrayTypeStyle: Array brackets at illegal position.
Error: src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java:[11] (blocks) NeedBraces: 'for' construct must use '{}'s.
Error: src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java:[19,19] (misc) ArrayTypeStyle: Array brackets at illegal position.
Error: src/main/java/g0301_0400/s0349_intersection_of_two_arrays/Solution.java:[20] (blocks) NeedBraces: 'for' construct must use '{}'s.

ThanhNIT added 3 commits

December 11, 2021 22:32


 Update Solution.java

0324a03


 format code

fb87b97


 Update Solution.java

eef5bc5

Copy link

Owner Author

javadev commented Dec 11, 2021 •

edited

Loading

There is sonar warning

IMG_20211211_174200


 Update Solution.java

d8af2d4

@sonarqubecloud

Copy link

sonarqubecloud bot commented Dec 11, 2021

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.4% 88.4% Coverage
0.0% 0.0% Duplication

@javadev javadev merged commit df1e4d0 into javadev:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@javadev @ThanhNIT @TristianMa