-
Notifications
You must be signed in to change notification settings - Fork 35
fix: expose prefer_feed_title through config.py/util.py, not just the constructor - #144
Open
Smengerl wants to merge 1 commit into
Open
fix: expose prefer_feed_title through config.py/util.py, not just the constructor #144Smengerl wants to merge 1 commit into
Smengerl wants to merge 1 commit into
Conversation
... constructor j6k4m8#129 added RSSFeedStoryProvider(prefer_feed_title=...) and described it as something callers could "opt in per source" - the same language used for every other per-source RSS option, all of which are set via the config file. But config.py's "rss" schema never listed prefer_feed_title as an optional field, and util.py's construct_story_providers_from_source_configs never passed it through even if it somehow got past validation. Concretely: {"type": "rss", ..., "prefer_feed_title": true} in a config file raises "Unknown field(s) in source #1: prefer_feed_title" - the option is unreachable from the CLI/config path j6k4m8#129's own description promised, only usable by constructing RSSFeedStoryProvider directly in Python. Wire it through the same way byline/body_source already are: add it to the "rss" schema's optional fields, validate it as a bool, and add it to util.py's allow-list.
Smengerl
force-pushed
the
fix/rss-prefer-feed-title-config-wiring
branch
from
August 18, 2026 19:46
0b62ae1 to
66bdf8e
Compare
Smengerl
added a commit
to Smengerl/goosepaper-logicpuzzles
that referenced
this pull request
Aug 21, 2026
Marks the PRs actually merged upstream since the table was last touched (j6k4m8#118-120, j6k4m8#122, j6k4m8#126, j6k4m8#129, j6k4m8#130, j6k4m8#134, j6k4m8#135, j6k4m8#137, j6k4m8#141), notes j6k4m8#123 as closed in favor of feature/puzzle-explanations, and adds the four rows that were missing entirely: j6k4m8#141 (fix/rss-absolute-url-wrapper-leak, merged), j6k4m8#142 (fix/rss-image-embedding, closed in favor of j6k4m8#145), j6k4m8#144 (fix/rss-prefer-feed-title-config-wiring, open), and j6k4m8#145 (feature/render-time-image-sizing, open).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#129 added
RSSFeedStoryProvider(prefer_feed_title=...)and described it as something callers could "opt in per source" - the same language used for every other per-source RSS option, all of which are set via the config file. Butconfig.py's"rss"schema never listedprefer_feed_titleas an optional field, andutil.py'sconstruct_story_providers_from_source_configsnever passed it through even if it somehow got past validation.Concretely:
{"type": "rss", ..., "prefer_feed_title": true}in a config file raises"Unknown field(s) in source #1: prefer_feed_title"- the option is unreachable from the CLI/config path #129's own description promised, only usable by constructingRSSFeedStoryProviderdirectly in Python.Wire it through the same way
byline/body_sourcealready are: add it to the"rss"schema's optional fields, validate it as a bool, and add it toutil.py's allow-list.Testing
construct_story_providers_from_source_configsactually passes it through to the constructor (the exact gap this closes).