Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
	## 2026年04月30日 - Refactored fs.readFileSync calls
	Learning: Calling `.toString()` on the Buffer returned by `fs.readFileSync(path)` causes unnecessary intermediate memory allocations and string conversion overhead. Passing the encoding directly as `fs.readFileSync(path, 'utf8')` is faster and more memory efficient.
	Action: Always prefer `fs.readFileSync(path, 'utf8')` over chaining `.toString()` in Node.js scripts.

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -26,7 +26,7 @@ describe('devices info', () => {
		const file = path.join(projectRoot, '.expo', 'devices.json');
		expect(fs.existsSync(file)).toBe(true);

	const { devices } = JSON.parse(fs.readFileSync(file, 'utf8').toString());
	const { devices } = JSON.parse(fs.readFileSync(file, 'utf8'));
		expect(devices.length).toBe(1);
		expect(devices[0].installationId).toBe('test-device-id');
		});
Expand Down

5 changes: 3 additions & 2 deletions packages/@expo/cli/src/utils/mergeGitIgnorePaths.ts

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -35,8 +35,9 @@ export function mergeGitIgnorePaths(
		return null;
		}

	const targetGitIgnore = fs.readFileSync(targetGitIgnorePath).toString();
	const sourceGitIgnore = fs.readFileSync(sourceGitIgnorePath).toString();
	// Read using utf8 directly to avoid buffer allocation
	const targetGitIgnore = fs.readFileSync(targetGitIgnorePath, 'utf8');
	const sourceGitIgnore = fs.readFileSync(sourceGitIgnorePath, 'utf8');
		const merged = mergeGitIgnoreContents(targetGitIgnore, sourceGitIgnore);
		// Only rewrite the file if it was modified.
		if (merged.contents) {
Expand Down

6 changes: 4 additions & 2 deletions packages/@expo/config-plugins/src/android/Package.ts

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -125,7 +125,8 @@ export async function renameJniOnDiskForType({
		filesToUpdate.forEach((filepath: string) => {
		try {
		if (fs.lstatSync(filepath).isFile() && ['.h', '.cpp'].includes(path.extname(filepath))) {
	let contents = fs.readFileSync(filepath).toString();
	// Read using utf8 directly to avoid buffer allocation
	let contents = fs.readFileSync(filepath, 'utf8');
		contents = contents.replace(
		new RegExp(transformJavaClassDescriptor(currentPackageName).replace(/\//g, '\\/'), 'g'),
		transformJavaClassDescriptor(packageName)
Expand Down Expand Up		@@ -207,7 +208,8 @@ export async function renamePackageOnDiskForType({
		filesToUpdate.forEach((filepath: string) => {
		try {
		if (fs.lstatSync(filepath).isFile()) {
	let contents = fs.readFileSync(filepath).toString();
	// Read using utf8 directly to avoid buffer allocation
	let contents = fs.readFileSync(filepath, 'utf8');
		if (path.extname(filepath) === '.kt') {
		contents = replacePackageName(contents, currentPackageName, kotlinSanitizedPackageName);
		} else {
Expand Down

Navigation Menu

Search code, repositories, users, issues, pull requests...