-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: [performance improvement] Avoid intermediate Buffer allocations when reading files#33
Conversation
...ns when reading files Replaced `fs.readFileSync(filepath).toString()` with `fs.readFileSync(filepath, 'utf8')` in: - `packages/@expo/config-plugins/src/android/Package.ts` - `packages/@expo/cli/src/utils/mergeGitIgnorePaths.ts` This avoids unnecessary intermediate Buffer allocations when reading text files. Co-authored-by: vishnu-madhavan-git <237662584+vishnu-madhavan-git@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.
When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.
I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!
For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!
New to Jules? Learn more at jules.google/docs.
For security, I will only act on instructions from the user who triggered this task.
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6f0998d8-05fb-4f86-bd72-28b4006e6b6b
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
- 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
bolt-perf-opt-fs-read-string-5025195328411783201
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
💡 What
Replaced instances of
fs.readFileSync(filepath).toString()withfs.readFileSync(filepath, 'utf8')inpackages/@expo/config-pluginsandpackages/@expo/cli.🎯 Why
When reading text files synchronously,
fs.readFileSyncreturns aBufferby default. Calling.toString()on that Buffer creates an intermediate object in memory before converting it to a string. By passing'utf8'directly tofs.readFileSync, Node.js skips creating the intermediate Buffer and returns the string directly, reducing memory allocations and garbage collection overhead. This is especially helpful inpackages/@expo/config-plugins/src/android/Package.tswhere it processes multiple files in a loop.📊 Impact
🔬 Measurement
Verify that the CLI and config-plugins tests continue to pass. The memory impact is minimal per-file but scales with the number of processed files in a project.
PR created automatically by Jules for task 5025195328411783201 started by @vishnu-madhavan-git