-
Notifications
You must be signed in to change notification settings - Fork 349
Open
Conversation
Assimp was trying to use its own implementation of stdint.h, but VS14 has stdint.h built in. Type redefinitions were causing the build to fail.
CMake's CHECK_FUNCTION_EXISTS function fails if the requested function is built-in, not a real function, or inlined (which is the case with snprintf()).
Spaces are necessary when using a macro; without a space, the macro will not be replaced, and will be treated as a literal suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to make a few tweaks to get everything compiling with VS14 CTP.
These fixes should not affect any other platforms.
I have not tried to build Polycode Lua yet, but that also should not be affected.