-
Notifications
You must be signed in to change notification settings - Fork 32
Protect declaration of LgdImageCreateFromPng* with GD_PNG feature test macro #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...t macro If GD_PNG is false, neither LgdImageCreateFromPng nor LgdImageCreateFromPngPtr would be implemented. We should avoid declaring them too.
Author
spacewander
commented
Oct 31, 2017
The corresponding patch could be applied to existing code:
diff --git a/luagd.c b/luagd.c index 9730ff7..98bc03e 100644 --- a/luagd.c +++ b/luagd.c @@ -2168,8 +2168,10 @@ static const luaL_Reg LgdFunctions[] = { "createFromGif", LgdImageCreateFromGif }, { "createFromGifStr", LgdImageCreateFromGifPtr }, #endif +#ifdef GD_PNG { "createFromPng", LgdImageCreateFromPng }, { "createFromPngStr", LgdImageCreateFromPngPtr }, +#endif { "createFromGd", LgdImageCreateFromGd }, { "createFromGdStr", LgdImageCreateFromGdPtr }, { "createFromGd2", LgdImageCreateFromGd2 },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GD_PNG is false, neither LgdImageCreateFromPng nor
LgdImageCreateFromPngPtr would be implemented.
See the implementation in https://github.com/ittner/lua-gd/blob/master/luagd.c#L417
We should avoid declaring them too.