Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

updated to angular 17.1.2 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manishsingh10895 wants to merge 5 commits into itsdevdom:develop
base: develop
Choose a base branch
Loading
from manishsingh10895:develop

Conversation

Copy link

@manishsingh10895 manishsingh10895 commented Feb 8, 2024

Updated packages.

I ran ncu to update package versions

Also this is first hacking around with jest in angular, and in jest.setup.ts line 16, updating transform property threw an error on running tests.
I have commented that code out, it works and as far as I google that workaround isn't needed anymore

"name": "angular-notifier",
"description": "A well designed, fully animated, highly customizable, and easy-to-use notification library for your Angular application.",
"version": "14.0.0",
"version": "14.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are adding breaking changes and the version should be 15

Comment on lines +16 to +23
// Object.defineProperty(document.body.style, 'transform', {
// value: () => {
// return {
// enumerable: true,
// configurable: true,
// };
// },
// });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's no longer needed, why are you commenting this code? maybe remove it?

Copy link
Author

@manishsingh10895 manishsingh10895 Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure about the working of this code, so didn't remove it at first.

Copy link

i just add
"angular-notifier": {
"@angular/common": ">=16.0.0",
"@angular/core": ">=16.0.0"
}
to my package.json file and it work just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@StepaZol StepaZol StepaZol left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /