-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(select-modal): hide focus option's border for ionic theme #30660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@OS-martacarlos
OS-martacarlos
requested a review
from a team
as a code owner
September 1, 2025 16:41
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@OS-martacarlos
OS-martacarlos
changed the title
(削除) fix(select-modal): hide focus option's border for ionic theme (削除ここまで)
(追記) fix: hide outlines for select with modal interface for ionic theme (追記ここまで)
Sep 1, 2025
@OS-martacarlos
OS-martacarlos
changed the title
(削除) fix: hide outlines for select with modal interface for ionic theme (削除ここまで)
(追記) fix(select-modal): hide focus option's border for ionic theme (追記ここまで)
Sep 1, 2025
@OS-martacarlos
OS-martacarlos
force-pushed
the
ROU-12158
branch
from
September 1, 2025 16:51
8fb0cb9 to
1c148d6
Compare
ShaneK
ShaneK
approved these changes
Sep 2, 2025
brandyscarney
brandyscarney
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
When opening a ion-select with a modal interface, the first option is focused and, as such, has a border.
This happens because an ion-item is being rendered, which has a specific styling for focused stated.
What is the new behavior?
When inside a
ion-select-modal, we don't want this specificion-itemstyling.Does this introduce a breaking change?