-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix: fix incorrect nav animations #28297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
added
the
package: angular
@ionic/angular package
label
Oct 6, 2023
FYI, @liamdebeasi :)
Hey @hoi4,
Thanks for making a separate PR! Does this PR already have an associated issue? If so, can you please link it in the PR template? If not, could you please make one and include a reproduction?
@liamdebeasi issue created and linked ✅
...d button fix(angular): respect direction set via the NavController fix(angular): adapt tests fix(angular): fixes
@hoi4
hoi4
force-pushed
the
fix-incorrect-nav-animations
branch
from
October 31, 2023 13:22
9363056 to
c8370d9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR is a follow-up to #28188.
Respective issue: #28307
It fixes an issue where the nav animation is sometimes incorrect when using the browser back and forward buttons to navigate through multiple pages.
The last nav animation in the following video should be
forward, but isbackinstead.Screen.Recording.2023年10月06日.at.08.29.22.mov
Angular's navigation ids are not a reliable solution because Angular does not reuse navigations.
From the docs:
Solution
Ionic already manages a navigation stack internally. Instead of "guessing" the nav animation direction based on Angular's router navigation ids, we can use the navigation stack to derive the required nav animation.
Recording with my changes:
Screen.Recording.2023年10月06日.at.08.41.26.mov
Does this introduce a breaking change?