This repository was archived by the owner on May 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 312
TSLint: add ability to exclude files and folders #1204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
commented
Oct 25, 2017
Looking forward to this getting merged! I'm having issues and this blocks the usage of a few pre-commit hooks in our project.
Could @danbucholtz take a look? It's been two months :s
MattiLehtinen
commented
Dec 17, 2017
Would appreciate this!
miquelferrerllompart
commented
Mar 6, 2018
Would appreciate this too!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
After upgrade to Ionic 3, tslint shows errors even for external typescript libraries inside the
node_modulesfolder.Changes proposed in this pull request:
envVaroption value to upper case (ionic_tslint->IONIC_TSLINT) (as the rest of functionalities)packageConfigoption value to lower case (IONIC_TSLINT->ionic_tslint) according to the docs Overriding Config Filestslint.jsonto be used. Now allows you to:tslint.jsonfile that is used.Fixes: #1203