-
Notifications
You must be signed in to change notification settings - Fork 32
feat(page): add --create-module option
#220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I look forward to seeing this feature merged!🙌
@raminfosystems
raminfosystems
Jul 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think default should set to be false so that we can keep existing changes without breaking it.
@raminfosystems
raminfosystems
Jul 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we could add some unit tests to validate these changes and keep align with existing behavior. :)
4f5535c to
407473f
Compare
Uh oh!
There was an error while loading. Please reload this page.
Aligning the page schematic with the component schematic, which already offers
--create-module. The default for the page schematic istrue, unlike the component schematic. To disable module creation,--create-module=falsemust be specified.fixes https://github.com/ionic-team/ionic-cli/issues/3586