Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add ability to set the Intercom API region by injecting the base URI #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eexit wants to merge 2 commits into intercom:master
base: master
Choose a base branch
Loading
from eexit:master

Conversation

@eexit
Copy link

@eexit eexit commented Oct 28, 2022

Why?

Out integration is based in another region than the US.

https://developers.intercom.com/building-apps/docs/rest-apis#available-endpoints

How?

Adding an optional parameter to the client constructor, defaulted with the US region to avoid any BC.

Copy link
Author

eexit commented Oct 28, 2022

Hi @dannyfallon,

Could you check why the CI is failing? It looks like the auth token is gone or expired..

Thanks!

Copy link
Contributor

Howdy @eexit, thanks for the ping. I've checked over the GitHub settings in our org and CircleCI is still there. I've also managed to make a new branch and Circle tested it for me. I can see other folks had their PRs work as recently as July and to my knowledge there's been no changes.

Can I ask if this is an issue with your own CircleCI setup? Can you log out of Circle and back in using GitHub then re-push your branch to see if that fixes it? If it doesn't I'll reach out to Circle to see what's up.

Copy link
Author

eexit commented Oct 28, 2022

@dannyfallon Awesome, thanks! CI is green now 🎉

dannyfallon reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colmdoyle colmdoyle colmdoyle approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /