Update Company::update method to support providing an id. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

MinDBreaK wants to merge 2 commits into intercom:master

Open

MinDBreaK wants to merge 2 commits into intercom:master from MinDBreaK:master

Conversation

Copy link

Allow update method to update a specified company with an id.

The API supports the update via ID but not the SDK. There is a workaround but it is not clean to use directly the client.

I added the ID in the arguments of the update method and added a BC layer to avoid breaking apps or having to bump a major version.

On next major version, the BC layer will need to be removed.

MinDBreaK added 2 commits


 Update companies::update()

a6dc4c1

Allow update method to update a specified company with an id.


 Remove trigger_deprecation

The function is a Symfony only function.