-
Notifications
You must be signed in to change notification settings - Fork 813
[Benchmarks] fix mutable default argument bugs#21309
Open
PatKamin wants to merge 1 commit intointel:sycl from
Open
[Benchmarks] fix mutable default argument bugs #21309PatKamin wants to merge 1 commit intointel:sycl from
PatKamin wants to merge 1 commit intointel:sycl from
Conversation
The shared mutable default `env_vars={}` in `utils.run()` was being
modified in-place by the `add_sycl=True` path (prepending sycl lib/bin
to PATH and LD_LIBRARY_PATH). Subsequent calls inherited those stale
values, causing the local sycl lib path to appear multiple times in
LD_LIBRARY_PATH (visible in build/run command logs).
input=None,
):
try:
if env_vars is None:
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not one-linear like above (env_vars = dict(env_vars) if env_vars else {})?
):
env_vars = env_vars.copy()
env_vars = dict(env_vars) if env_vars else {}
if ld_library is None:
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm why this ld_library change? does it make a difference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared mutable default
env_vars={}inutils.run()was being modified in-place by theadd_sycl=Truepath (prepending sycl lib/bin to PATH and LD_LIBRARY_PATH). Subsequent calls inherited those stale values, causing the local sycl lib path to appear multiple times in LD_LIBRARY_PATH (visible in build/run command logs).