Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de...#21295

Open
kekaczma wants to merge 1 commit intosycl from
defensive-enum-handling
Open

[UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de... #21295
kekaczma wants to merge 1 commit intosycl from
defensive-enum-handling

Conversation

@kekaczma
Copy link
Contributor

@kekaczma kekaczma commented Feb 16, 2026
edited
Loading

...vice info queries

Handle unknown device info queries gracefully by returning UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION instead of UR_RESULT_ERROR_INVALID_ENUMERATION or breaking to unreachable code.

This provides forward compatibility when newer SYCL runtimes query device info enums that don't exist in older UR adapters yet.

Changes:

  • CUDA adapter: Return UNSUPPORTED_ENUMERATION + add error logging
  • HIP adapter: Return UNSUPPORTED_ENUMERATION + add error logging
  • OpenCL adapter: Return UNSUPPORTED_ENUMERATION

@kekaczma kekaczma changed the title (削除) [UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de... (削除ここまで) (追記) [WIP][UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de... (追記ここまで) Feb 16, 2026
...vice info queries
Handle unknown device info queries gracefully by returning
UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION instead of
UR_RESULT_ERROR_INVALID_ENUMERATION or breaking to unreachable code.
This provides forward compatibility when newer SYCL runtimes query
device info enums that don't exist in older UR adapters yet.
Changes:
- CUDA adapter: Return UNSUPPORTED_ENUMERATION + add error logging
- HIP adapter: Return UNSUPPORTED_ENUMERATION + add error logging
- OpenCL adapter: Return UNSUPPORTED_ENUMERATION
- Remove unreachable return statements after default cases
Copy link
Contributor Author

Failing check is related with known issue #21114

Copy link
Contributor

@pbalcer please review - this should improve potential library mismatch issues in the adapters discovery path

@kekaczma kekaczma changed the title (削除) [WIP][UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de... (削除ここまで) (追記) [UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de... (追記ここまで) Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafNNN rafNNN Awaiting requested review from rafNNN rafNNN is a code owner automatically assigned from intel/llvm-reviewers-cuda

@pbalcer pbalcer Awaiting requested review from pbalcer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /