-
Notifications
You must be signed in to change notification settings - Fork 813
[Driver][NFC] Check pointer Arg before dereferencing.#21287
[Driver][NFC] Check pointer Arg before dereferencing. #21287srividya-sundaram wants to merge 3 commits intointel:sycl from
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like something that would benefit the community as it isn't specific to SYCL. Would this be better to just upstream instead of doing intel/llvm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are to SYCL specific checks here before some of these diagnostics are emitted (like SYCLSplitMode). Unless I am mis-understanding what you are referring to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are SYCL specific things here, but the fix itself can be applied to upstream and be pulled into intel/llvm as it also impacts OpenMP upstream behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the fix itself can be applied to upstream and be pulled into intel/llvm as it also impacts OpenMP upstream behaviors.
err_drv_sycl_thinlto_split_off is specific to intel/llvm only and is therefore handled here, while the other two diagnostics are addressed in the upstream patch.
@mdtoguchi
mdtoguchi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers please consider merging
Addresses: #21282