-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Conversation
Deliberately written with several review-bait patterns to give the Forge code-review skill something to flag. Not intended to be merged.
@naveen-kurra
naveen-kurra
left a comment
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changes in demo_review_target.go. The diff is small, but I found two correctness issues:
- DivideUnsafe can panic on division by zero.
- ParseHost uses manual string parsing that produces incorrect results for several valid URL forms.
Overall risk: medium.
}
return rest[:slash]
}
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Division by zero can panic at runtime
x = 0
}
return x * 2
}
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual URL host parsing is incorrect for several valid URL forms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo PR. Do not merge or review by hand — used to test the Forge code-review-github skill end-to-end. Will be closed after demo.