-
Notifications
You must be signed in to change notification settings - Fork 477
Exclude aggregate interface 'all' thas has missing error/drop fields#2385
Open
hpaluch-pil wants to merge 2 commits into
Open
Exclude aggregate interface 'all' thas has missing error/drop fields #2385hpaluch-pil wants to merge 2 commits into
hpaluch-pil wants to merge 2 commits into
Conversation
docmerlin
commented
Sep 4, 2020
Contributor
@hpaluch-pil Hey, man, this looks great, but I can't accept it without you signing the CLA :-( Without that, our lawyers won't let us accept code from outside PRs.
docmerlin
docmerlin
suggested changes
Oct 9, 2020
@docmerlin
docmerlin
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hpaluch-pil hey could you sign the CLA :-( Without that, our lawyers won't let us accept code from outside PRs.
hpaluch-pil
commented
Oct 12, 2020
Author
Hi @docmerlin !
I can sign CLA myself. But I don't dare to push my employer to sign CCLA, because it may cause substantial legal obligations and/or risks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
When I tried stock "net_alert" examples for Telegraf I found spurious errors in my
/var/log/kapacitor/kapacitor.log:After a bit of debug it turned out that it is caused by Telegraf inserting data for virtual interface
allthat ismissing some fields, including these error and drop fields required by these Tasks.
So excluding interface
allfrom results seems to fix this problem.Please let me know what you think about this issue and proposed solution.
Required for all non-trivial PRs