-
Notifications
You must be signed in to change notification settings - Fork 188
write 2 points in example.py #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: write 2 points in example.py
codecov-commenter
commented
Dec 5, 2024
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 90.20%. Comparing base (
ab16384) to head (c250e8e).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@ ## master #683 +/- ## ========================================== - Coverage 90.28% 90.20% -0.08% ========================================== Files 40 40 Lines 3541 3533 -8 ========================================== - Hits 3197 3187 -10 - Misses 344 346 +2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@bednar
bednar
requested review from
vlastahajek
and removed request for
karel-rehor
December 5, 2024 14:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
Create and write 2 points instead of one in the example.py file.
Previously, the second write (with the line_protocol) erased the first write (with the Point structure) as timestamps are the same. Besides, the WritePrecision.MS made the line_protocol time conversion to somewhere in February 1970 (at time of writing), instead of current date & time.
So it is proposed here to write two distinct points to improve example understanding, and remove the WritePrecision.MS when writing with line_protocol, as is done in other examples, in order to write both points at the timestamp of execution.
Checklist