-
Notifications
You must be signed in to change notification settings - Fork 188
Implement flush in write_api #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 90.52%. Comparing base (
012c50a) to head (b322815).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@ ## master #678 +/- ## ========================================== + Coverage 90.49% 90.52% +0.03% ========================================== Files 40 40 Lines 3534 3535 +1 ========================================== + Hits 3198 3200 +2 + Misses 336 335 -1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minsungoh, thanks for your PR 👍. Please ensure all items in our Checklist are completed:
image
Sorry for late reply. i have problem in pytest. is there a auto config for test or should i input my own config? then what file should i change? there are config.ini, config.json, config.toml in tests/.
If you are using Linux or MacOS, you should be able to run tests following this guide - https://github.com/influxdata/influxdb-client-python?tab=readme-ov-file#local-tests
eb6fe83 to
1249f41
Compare
There's only mocking tests in tests/test_WriteApiBatching.py, so i made a class extends BaseTest for testing flush works. however, is there a better way to verify that record's saved on influxdb instead of sleep?
b322815 to
8c0fd26
Compare
Uh oh!
There was an error while loading. Please reload this page.
Proposed Changes
write_api is send data when it close or delete on batching mode. but i want to reuse same object. so i implement flush function as simply call on_complete
Checklist
pytest testscompletes successfully