-
Notifications
You must be signed in to change notification settings - Fork 325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. My suggestions are mostly for following our style and "tightening up". We should add examples where noted ASAP, but it shouldn't necessarily hold up publishing when the feature is ready.
MeelahMe
commented
Mar 19, 2025
Thank you for the suggestions and help! I should probably go slower and triple check that I am using the Google developers documentation style guide. @jstirnaman
Thank you for the suggestions and help! I should probably go slower and triple check that I am using the Google developers documentation style guide. @jstirnaman
Ideally, Vale should be catching violations as well, but I think we're missing some config for the newer directories.
You can tell CoPilot to always use it and suggest fixes. I also give it an alias, like
If I say "gdd", it means Google Developer Documentation style.
Use gdd and condense the selection...
@jstirnaman
jstirnaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commands should be used in the process above, not influxdb_iox
@ritwika314
ritwika314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, we should save the material for when more self-support features are added. Thank you!
@jstirnaman
jstirnaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the notes here, I'm pushing an update to your branch--I'll PR so you can see the diff.
Co-authored-by: Jason Stirnaman <jstirnaman@influxdata.com>
Co-authored-by: Jason Stirnaman <jstirnaman@influxdata.com>
Co-authored-by: Jason Stirnaman <jstirnaman@influxdata.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
...h support assistance
- Add directory and frontmatter - Revise content to be Cloud Dedicated specific, omitting implementation and config detail that will be handled by InfluxData Support - Fix code samples - Organize, clean up headings - TODO: Comment out influxctl and API code if necessary (until features are completed) - TODO: Verify details with PM - TODO: Move content as noted in the iceberg-for-snowflake.md comment
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
- Merge fixes - Provide instruction for checking snapshot status - Cleanup
3a44b1e to
0cd0cde
Compare
Uh oh!
There was an error while loading. Please reload this page.
Description
To introduce documentation for the new Iceberg integration with Snowflake for InfluxDB Cloud Dedicated. To create documentation that allows users to export time series data snapshots into Apache Iceberg format and query them directly from Snowflake—without the need for complex ETL processes.
To-do
Why This Matters
This documentation gives users the information they need to request access and understand the setup and usage of the integration clearly and confidently.