Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on May 30, 2019. It is now read-only.

Read server's ISUPPORT and get prefix there#101

Open
14mRh4X0r wants to merge 1 commit intoindrora:master from
14mRh4X0r:isupport-prefix
Open

Read server's ISUPPORT and get prefix there #101
14mRh4X0r wants to merge 1 commit intoindrora:master from
14mRh4X0r:isupport-prefix

Conversation

@14mRh4X0r
Copy link
Contributor

@14mRh4X0r 14mRh4X0r commented Oct 23, 2015

Also stores the ISUPPORT parameters in an easily accessible HashMap and fixes a slight parsing bug with IRCv3 message tags

Copy link
Owner

indrora commented Oct 23, 2015

There's deeper places that this should be handled.

Notably, pIRCbot is hard-coded to say that v means + and o means @.

Copy link
Owner

indrora commented Oct 23, 2015

Second quick check: how well does the IETF document line up with http://www.irc.org/tech_docs/005.html ?

Copy link
Contributor Author

I'll update this pull request later with an implementation on a deeper level. The IETF document matches the irc.org doc as far as I can tell, but the latter does provide more information about real-world implementations.

Copy link
Owner

indrora commented Nov 2, 2015

I'd like IRCService to be able to tell what the ISUPPORT blocks state. This way, we can strip out the nick prefixes (and handle things like the absolutely strange $foo channel type that I encountered)

Copy link
Contributor Author

As my local version is now, PircBot has a Map<String, String> getISupport(). It requires more rewriting than I anticipated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /