-
Notifications
You must be signed in to change notification settings - Fork 3
Add tests for listdir_matching
#122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Implement tests for non-recursive and recursive matching. * Validate fullpath and regex matching functionality. * Ensure correct sorting behavior for file names.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27%. Comparing base (1a0f954) to head (170b066).
Additional details and impacted files
@@ Coverage Diff @@ ## devel #122 +/- ## ==================================== + Coverage 25% 27% +2% ==================================== Files 25 25 Lines 1766 1766 ==================================== + Hits 435 470 +35 + Misses 1331 1296 -35
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
listdir_matching (追記ここまで)
ehrenfeu
commented
Jan 21, 2026
As indicated by codecov, there are still quite some paths in the function that are not covered by tests:
https://app.codecov.io/gh/imcf/python-imcflibs/pull/122/blob/src/imcflibs/pathtools.py#L223
To me, the level of complexity / conditional nesting / ... of listdir_matching is so high that sooner or later it will blow up if it's not fully covered.
* Implement test for invalid regex returning an empty list. * Add test for recursive regex matching that verifies absolute paths.
Fix #119