Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Formatted spacing and updated documentation #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronodhirSoumik wants to merge 2 commits into iluwatar:master
base: master
Choose a base branch
Loading
from ronodhirSoumik:bugfix/added-spacing-refactoration

Conversation

Copy link

@ronodhirSoumik ronodhirSoumik commented May 31, 2025

Pull Request Template

What does this PR do?

This pull request formats redundant spacing in common pom.xml and rewrites documentation for removeSubscriber function of Publish-Subscribe model.

Copy link

github-actions bot commented May 31, 2025 •
edited
Loading

PR Summary

This PR refactors redundant spacing in the pom.xml file and updates the documentation for the removeSubscriber function in the Publish-Subscribe model. The pom.xml file's module list is reformatted to remove redundant spacing, improving readability. The documentation for the removeSubscriber function is updated for clarity and accuracy.

Changes

File Summary
pom.xml Refactored redundant spacing in the module list, improving readability and maintainability. No functional changes were introduced.
publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/model/Topic.java Updated documentation for the removeSubscriber function. The description now clearly states that the function removes a subscriber from the list of subscribers.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

Review Summary

Commits Considered (2)
  • 7330bd9: Updated documentation of remove subscriber in publish-subscribe model
  • 7d50833: Refactored redundant spacing in pom.xml
Files Processed (2)
  • pom.xml (2 hunks)
  • publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/model/Topic.java (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
  • pom.xml [234-234]

    readability: "Inconsistent indentation in pom.xml"

  • pom.xml [247-248]

    readability: "Inconsistent indentation in pom.xml"

  • publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/model/Topic.java [53-57]

    enhancement: "Add usage example to removeSubscriber documentation"

@ronodhirSoumik ronodhirSoumik changed the title (削除) Bugfix/added spacing refactoration (削除ここまで) (追記) Formatted spacing and updated documentation (追記ここまで) May 31, 2025
Copy link

This PR is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle によって変換されたページ (->オリジナル) /