-
Notifications
You must be signed in to change notification settings - Fork 101
K Closest Points to Origin #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem/solution looks good to me. Could you fix the linter issue by running npx eslint LeetcodeProblems LeetcodeProblemsTests --fix? thanks!
I just enabled the linter to run on this PR. You can also check lint errors locally by running npx eslint LeetcodeProblems LeetcodeProblemsTests
I resolved all the linter errors, please have a check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some linting errors in LeetcodeProblems/Algorithms/K_Closest_Points_to_Origin.js file
Screen Shot 2022年10月23日 at 10 45 32 AM
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the readme? It deleted all the previous staff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes did it now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see what's going on. Could you rebase? A bad commit has been reverted and it caused to have two readmes. #78
This reverts commit 47220c6.
I hope its right now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good now, Could you rebase with the latest master so that I can hit rebase and merge and add you as a contributor?
Revert 78 revert 75 patch 3
Could you merge it now?
Could you rebase with the latest master? An easy way to do it would be to squash all your 10 commits into 1 and then rebase with the latest master. I can do it for you but GitHub won't mark you as a contributor if I'm not mistaken.
No description provided.