-
Notifications
You must be signed in to change notification settings - Fork 101
[2428] Hour Glass Sum #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2428] Hour Glass Sum #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! thanks for contributing! 🙌
The solution looks good to me. I'm curious if we could reduce the N**2 computation time.
Could you add an entry in the changelog to the problem? and write a file test with a few examples? You can follow this PR #39. After that, we can merge the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example of the matrix here? It could be with text if the original problem use images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use an explanation of why it's 30.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the code @ignacio-chiazzo Added as per the format in PR #39.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please review again?
N**2 computation time
For the computation time, this is the best computation time for this problem, verified with Leetcode discuss panel as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good to me.
I left a comment on the readme, but otherwise, it looks great. #49
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The problems are sorted by complexity, could you move this problem to the medium section? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the ordering @ignacio-chiazzo
3bd0699 to
3334cb2
Compare
Thank you!
Hi @ignacio-chiazzo your repo has the tag hacktoberfest-accepted but the hackoctober official page says otherwise[ that this repo is not registered]. Can you tell me if its accepted or not?
Uf! I just realized that the tag was invalid. The tag is hacktoberfest-accepted
It should be fixed now. Let me know if you don't receive the count of the PR.
Yeah ! getting the following msg
AWESOME! YOUR PR/MR HAS BEEN ACCEPTED BY A MAINTAINER AND IS NOW IN A SEVEN-DAY REVIEW PERIOD. NO ACTION IS NEEDED, AND ASSUMING YOUR PR/MR IS STILL ACCEPTED AFTER SEVEN DAYS IT WILL COUNT TOWARDS YOUR PARTICIPATION IN HACKTOBERFEST!
thanks
Uh oh!
There was an error while loading. Please reload this page.
Solution for Leetcode Problem: 2428
https://leetcode.com/problems/maximum-sum-of-an-hourglass/description/
Submitting as part of hackoctober Fest. Please approve if you find it correct, it is accepted solution on leetcode #49