Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add customizable highlighted regions to cells#384

Open
parrotmac wants to merge 1 commit intoiddan:master from
parrotmac:ip/feat/highlight
Open

feat: add customizable highlighted regions to cells #384
parrotmac wants to merge 1 commit intoiddan:master from
parrotmac:ip/feat/highlight

Conversation

@parrotmac
Copy link

@parrotmac parrotmac commented Mar 8, 2024
edited
Loading

Hey @iddan, thanks for the great library!

This change enables users to specify highlighted regions of the sheet. My goal is to enable collaborative editing a'la Google Sheets, but it could also be used for user feedback about validation, or something else entirely. I aimed to reuse and somewhat emulate the Selection types and code path. You'll also notice I had to add an initial effect to the Cell component so that highlighting would be possible before the first user interaction. Without that, there isn't bounding rect info available to set the highlighting component coordinates.

Please let me know if there are any changes or additions requested.

Cheers!

react-spreadsheet-highlight-demo.mov

@parrotmac parrotmac marked this pull request as ready for review March 8, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Comments

AltStyle によって変換されたページ (->オリジナル) /