-
Notifications
You must be signed in to change notification settings - Fork 1k
Add support for DEFLATE64 algorithm when extracting from zip archive #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are aware that is a costly copy operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am. But in this particular case I don't think that it is significant.
piksel
commented
Dec 23, 2022
This currently fails 4 tests, and I am not too eager in taking in a whole new Deflate implementation (1800 LoC 😓).
I did some PoC testing in c9589cf to see if it could be implemented by allowing the window and max distance to be customized in the existing Deflater.
It still needs more testing and a Inflator support, but it looks promising...
elitzamarinova
commented
Dec 23, 2022
Yes, looks promising.
I took a look today at the failings in the tests, seems like the ZipEntry in the ZipInputStream got null somehow.
Add support for DEFLATE64 algorithm when extracting from zip archive:
The content of the new classes is borrowed from DEFLATE64 support implementation for DotNetZip which on its part contains modified code from the .NET Core Libraries (CoreFX and System.IO.Compression/DeflateManaged) where deflate64 decompression is implemented.
Other changes are implemented in order to support forward-only stream.