-
Notifications
You must be signed in to change notification settings - Fork 1k
Add support for old Info-ZIP extra block for Unix #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for old Info-ZIP extra block for Unix #660
Conversation
...x Extra Field type 1)
Codecov Report
@@ Coverage Diff @@ ## master #660 +/- ## ========================================== - Coverage 73.28% 73.04% -0.25% ========================================== Files 68 68 Lines 8304 8339 +35 ========================================== + Hits 6086 6091 +5 - Misses 2218 2248 +30
Continue to review full report at Codecov.
|
@piksel
piksel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks overall good, but there are no tests.
Uh oh!
There was an error while loading. Please reload this page.
SharpZipLib currently supports reading timestamps from the "Extended Timestamp Extra Field" (
0x5455).This PR adds support for the older (but still often seen in new
.zipfiles) "Info-ZIP Unix Extra Field (type 1)" (0x5855).I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.