Skip to content

Navigation Menu

Sign in
Sign up

Handle 429 status code in response gracefully. - #21

Open
m-aciek wants to merge 1 commit into
hyperwallet:master from
m-aciek:patch-1
Open

Handle 429 status code in response gracefully. #21
m-aciek wants to merge 1 commit into
hyperwallet:master from
m-aciek:patch-1

Conversation

@m-aciek

@m-aciek m-aciek commented Sep 19, 2019

Copy link
Copy Markdown

Closes #20.

MichalRogowski, mturlo, michalbon, and borwoj reacted with thumbs up emoji

m-aciek commented Dec 2, 2019

Copy link
Copy Markdown
Author

@igusar-epam, @dyurchenko-epam could you take a look at it? That change would prevent us from internal library crash on internal check. And would allow us to not fork HW SDK, but use original one.

MichalRogowski reacted with thumbs up emoji

m-aciek commented Dec 2, 2019

Copy link
Copy Markdown
Author

Now we just get:

hyperwallet.exceptions:HyperwalletAPIException: Invalid Content-Type specified in Response Header
Traceback (most recent call last):
...
File ".../hyperwallet/api.py", line 117, in getUser
File ".../hyperwallet/utils/apiclient.py", line 156, in doGet
File ".../hyperwallet/utils/apiclient.py", line 116, in _makeRequest
File ".../hyperwallet/utils/apiclient.py", line 208, in __checkResponseHeaderContentType

so the original cause is obscured.

Copy link
Copy Markdown
Contributor

@m-aciek I think this change is ok. I can approve this pull request if you add me as a reviewer. Also you can add @aseveryn-hw to this discussion. He has a lot more experience in SDK programming.

m-aciek commented Dec 3, 2019

Copy link
Copy Markdown
Author

@igusar-epam thank you! But it looks like I don't have permissions to assign a review :( [1].

[1] https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review

Copy link
Copy Markdown
Contributor

@m-aciek I added myself as a reviewer and approved it. I also added other team members to it.

m-aciek commented Dec 16, 2019

Copy link
Copy Markdown
Author

@vkorotchenko @wmews-hw @aseveryn-hw what do you think of this small change?

Comment thread hyperwallet/utils/apiclient.py Outdated
Comment thread hyperwallet/utils/apiclient.py Outdated
m-aciek requested review from wmews-hw and removed request for aseveryn-hw July 21, 2020 11:53

m-aciek commented Sep 23, 2020

Copy link
Copy Markdown
Author

@wmews-hw Hi, I've corrected my pull request. Could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkorotchenko vkorotchenko Awaiting requested review from vkorotchenko
@wmews-hw wmews-hw Awaiting requested review from wmews-hw
2 more reviewers
@igusar-epam igusar-epam igusar-epam approved these changes
@dyurchenko-epam dyurchenko-epam dyurchenko-epam approved these changes
Reviewers whose approvals may not affect merge requirements

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Library crashes on Too Many Requests response

AltStyle によって変換されたページ (->オリジナル) /